Disable overscan compensation for external displays on iOS #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtak-
reviewed
Aug 2, 2019
src/platform_impl/ios/window.rs
Outdated
| @@ -165,7 +165,7 @@ impl Inner { | |||
| let uiscreen = match monitor { | |||
| Some(Fullscreen::Exclusive(video_mode)) => { | |||
| let uiscreen = video_mode.video_mode.monitor.ui_screen() as id; | |||
| let () = msg_send![uiscreen, setCurrentMode: video_mode.video_mode.screen_mode]; | |||
| msg_send![uiscreen, setCurrentMode: video_mode.video_mode.screen_mode]; | |||
There was a problem hiding this comment.
winit has been using explicit return types to guard against msg_send! calls deducing to the ! type after never is stabilized (presently they deduce to () when the type is not explicitly stated). Previous attempts to stabilize ! have caused many bugs in winit. See #428 and the other github activity referencing it. If/when never is stabilized, these calls are likely to deduce to ! causing UB.
I'll open an issue on gfx as well, as I know they also have unconstrained types stemming from msg_send.
There was a problem hiding this comment.
Thank you! I've addressed the issue here.
|
Tested on AppleTV. Works. Thanks! |
|
Thank you for testing this! I've rebased this against |
mtak-
approved these changes
Aug 6, 2019
cheako
pushed a commit
to cheako/winit
that referenced
this pull request
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo fmthas been run on this branchCHANGELOG.mdif knowledge of this change could be valuable to usersr? @mtak-